Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jot-jt
Copy link
Contributor

@jot-jt jot-jt commented Jan 11, 2024

This fixes an issue where read_images_binary() throws an exception when decoding image names with multi-byte characters.

UTF-8 encodes characters using one to four bytes, so decoding byte-by-byte sometimes won't work if a character is encoded with more than one byte. For instance, if a character is encoded using three bytes, all three bytes need to be passed into .decode("utf-8") for it to return the proper character. This pull request decodes the entire image name at once to avoid this issue.

@ahojnnes ahojnnes merged commit 5d4535a into colmap:main Jan 11, 2024
@ahojnnes
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants