-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Migrate pycolmap #2367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate pycolmap #2367
Conversation
Co-authored-by: Philipp Lindenberger <[email protected]> Co-authored-by: Mihai Dusmanu <[email protected]>
6454576 to
acdffe4
Compare
ahojnnes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for this monumental effort. Instead of trying to migrate from Github CI to ADO pipelines, we could also try to convert the existing ones to github. Both run on the same machines (afaik) in the end but the Github ones integrate more nicely with direct log output, etc.
|
We should probably also setup vcpkg binary caching? |
|
@ahojnnes PTAL. I would also prefer to have everything under GitHub CI instead of ADO, it looks easier to manage and better integrated. We do already have binary caching for vcpkg, see comment above. |
|
Feel free to merge if you're happy with it. |
google-build-using-namespace- we need to useusing namespace colmap;because pybind doesn't play well with namespaces.-checks=-google-build-using-namespace*Will be addressed in later PRs:
SetPRNGSeedand remove its calls inpycolmap/estimatorspycolmap/feature/sift.hcc @mihaidusmanu @Phil26AT @tsattler