Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sarlinpe
Copy link
Member

@sarlinpe sarlinpe commented Jan 26, 2024

  • I would prefer to keep the CI running on GitHub actions for now and move to Azure Pipelines only later. To minimize the binary sizes we only build a subset of COLMAP features (no GUI, no CGAL) so we anyway need separate build job. With caching it takes <20min to run.
  • The code mostly follows conventions of COLMAP and passes all clang-tidy checks except google-build-using-namespace - we need to use using namespace colmap; because pybind doesn't play well with namespaces.
    • I will add a CI job for Clang-Tidy in a separate PR with -checks=-google-build-using-namespace*

Will be addressed in later PRs:

  • Move exception checks to COLMAP
  • Bind SetPRNGSeed and remove its calls in pycolmap/estimators
  • Replace calls to FreeImage in pycolmap/feature/sift.h
  • CI with Clang-Tidy for pycolmap
  • Better binary caching for vcpkg
  • More tests

cc @mihaidusmanu @Phil26AT @tsattler

@sarlinpe sarlinpe marked this pull request as draft January 26, 2024 18:09
Co-authored-by: Philipp Lindenberger <[email protected]>
Co-authored-by: Mihai Dusmanu <[email protected]>
@sarlinpe sarlinpe force-pushed the sarlinpe/migrate-pycolmap branch from 6454576 to acdffe4 Compare January 26, 2024 18:14
@sarlinpe sarlinpe marked this pull request as ready for review January 27, 2024 00:07
Copy link
Contributor

@ahojnnes ahojnnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this monumental effort. Instead of trying to migrate from Github CI to ADO pipelines, we could also try to convert the existing ones to github. Both run on the same machines (afaik) in the end but the Github ones integrate more nicely with direct log output, etc.

@ahojnnes
Copy link
Contributor

We should probably also setup vcpkg binary caching?

@sarlinpe
Copy link
Member Author

sarlinpe commented Jan 27, 2024

@ahojnnes PTAL. I would also prefer to have everything under GitHub CI instead of ADO, it looks easier to manage and better integrated. We do already have binary caching for vcpkg, see comment above.

@sarlinpe
Copy link
Member Author

Feel free to merge if you're happy with it.

@ahojnnes ahojnnes merged commit 49e1dcd into colmap:main Jan 27, 2024
@sarlinpe sarlinpe deleted the sarlinpe/migrate-pycolmap branch January 27, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants