Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sarlinpe
Copy link
Member

@sarlinpe sarlinpe commented Feb 7, 2024

  • Simplify the interface of EstimateTriangulation to ease its Python bindings
  • Abstract duplicated code in the IncrementalTriangulator

@sarlinpe sarlinpe changed the title Bugfix in pycolmap.estimate_triangulation Simplify the low-level triangulation API Feb 8, 2024
@sarlinpe sarlinpe marked this pull request as ready for review February 8, 2024 09:34
@sarlinpe sarlinpe requested a review from ahojnnes February 8, 2024 09:34
Copy link
Contributor

@ahojnnes ahojnnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, apart from a small comment.

@ahojnnes ahojnnes enabled auto-merge (squash) February 8, 2024 22:30
@sarlinpe sarlinpe requested a review from ahojnnes February 9, 2024 11:06
@ahojnnes ahojnnes merged commit 7d91034 into main Feb 9, 2024
@ahojnnes ahojnnes deleted the sarlinpe/bugfix-py-triangulator branch February 9, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants