You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt all the controllers except for feature extraction and matching to use the new logic. Each controller inherits from BaseController, and in the ui a ControllerThread is instantiated.
Move ControllerThread in the util, such that there is no "Thread"-related practice in the other folder. Maybe we should separate class Thread from ThreadPool and JobQueue at util/threading.h and move Thread class and ControllerThread class completely into the ui folder.
Now feature extraction and feature matching still inherits from the Thread class since in Python we will use different logics. However, because of this the AutomaticReconstructionController needs to inherit from Thread as well to support the Stopping function for the feature extractor and matcher. While this can potentially be resolved by adding SignalInvalidSetup, SignalValidSetup, and CheckValidSetup into the controller with a boolean valued callback, this might be a little overcomplication in the class design since this is not relevant to pybind for now. It depends on whether we want to totally disentangle the Thread outside the ui @ahojnnes@sarlinpe
If needed I can make the update on the feature extraction and matcher later as well in a separate PR.
OK unfortunately keeping the BaseController class in the controllers folder and inheriting it in the undistorters will result in cyclic dependency between the controllers folder and image folder, so I have to move the BaseController implementation to util folder as well.
undistortion.cc is huge (1.1k LOC), it would make sense to split it into a controller (that would go into controllers/) and the actual undistortion utils. This would also make it easier to write bindings for it.
undistortion.cc is huge (1.1k LOC), it would make sense to split it into a controller (that would go into controllers/) and the actual undistortion utils. This would also make it easier to write bindings for it.
Sure sounds good. But then how about the mvs if we put BaseController back to the controllers folder? Patchmatch stereo and fusion also uses the controller, making the controller folder a dependency for the mvs. This also does not feel like an ideal dependency graph conceptually.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the updates as follows:
ThreadfromThreadPoolandJobQueueatutil/threading.hand moveThreadclass andControllerThreadclass completely into the ui folder.Now feature extraction and feature matching still inherits from the Thread class since in Python we will use different logics. However, because of this the
AutomaticReconstructionControllerneeds to inherit from Thread as well to support the Stopping function for the feature extractor and matcher. While this can potentially be resolved by addingSignalInvalidSetup,SignalValidSetup, andCheckValidSetupinto the controller with a boolean valued callback, this might be a little overcomplication in the class design since this is not relevant to pybind for now. It depends on whether we want to totally disentangle the Thread outside the ui @ahojnnes @sarlinpeIf needed I can make the update on the feature extraction and matcher later as well in a separate PR.