Thanks to visit codestin.com
Credit goes to github.com

Skip to content

model aligner with type "custom" does not update reconstruction #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahojnnes merged 6 commits into from
Feb 21, 2024
Merged

model aligner with type "custom" does not update reconstruction #2433

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3ed9c36
model aligner with type "custom" does not update reconstruction
lpanaf Feb 20, 2024
558e503
d
ahojnnes Feb 21, 2024
f0a339d
Merge branch 'main' into main
ahojnnes Feb 21, 2024
55eaa82
d
ahojnnes Feb 21, 2024
906a567
Merge branch 'main' into main
ahojnnes Feb 21, 2024
0669f24
d
ahojnnes Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions src/colmap/exe/model.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,6 @@ int RunModelAligner(int argc, char** argv) {
Reconstruction reconstruction;
reconstruction.Read(input_path);
Sim3d tform;
bool alignment_success = true;

if (alignment_type == "plane") {
PrintHeading2("Aligning reconstruction to principal plane");
Expand All @@ -356,6 +355,13 @@ int RunModelAligner(int argc, char** argv) {
ransac_options,
&tform);

if (!alignment_success) {
LOG(ERROR) << "=> Alignment failed";
return EXIT_FAILURE;
}

reconstruction.Transform(tform);

std::vector<double> errors;
errors.reserve(ref_image_names.size());

Expand Down Expand Up @@ -402,17 +408,13 @@ int RunModelAligner(int argc, char** argv) {
}
}

if (alignment_success) {
LOG(INFO) << "=> Alignment succeeded";
reconstruction.Write(output_path);
if (!transform_path.empty()) {
tform.ToFile(transform_path);
}
return EXIT_SUCCESS;
} else {
LOG(INFO) << "=> Alignment failed";
return EXIT_FAILURE;
LOG(INFO) << "=> Alignment succeeded";
reconstruction.Write(output_path);
if (!transform_path.empty()) {
tform.ToFile(transform_path);
}

return EXIT_SUCCESS;
}

int RunModelAnalyzer(int argc, char** argv) {
Expand Down