Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ahojnnes
Copy link
Contributor

@ahojnnes ahojnnes commented Apr 7, 2024

  • Propagates missing public link dependencies that prevent ceres headers from being found.
  • These new dependencies revealed a circular dependency between scene/feature that is broken by a new feature_types library.

@sarlinpe
Copy link
Member

sarlinpe commented Apr 7, 2024

  1. Wouldn't it be simpler to merge feature/types.h into util/types.h?
  2. The pycolmap CI is down because liblzma is now down following the vulnerability discovered in xz: [liblzma] port uses compromised version microsoft/vcpkg#37839 Best is to wait that this gets fixed in vcpkg.

@ahojnnes
Copy link
Contributor Author

ahojnnes commented Apr 9, 2024

  1. I would like to avoid shoving more types into the global util/types to avoid a global knot in the dependency graph.
  2. Thanks, I'll make a vcpkg update in a separate PR first.

@sarlinpe
Copy link
Member

sarlinpe commented Apr 11, 2024

liblzma is now back online (no need to update VCPKG) but freeimage now fails in all VCPKG-based pipelines.

@ahojnnes ahojnnes enabled auto-merge (squash) April 14, 2024 16:16
@ahojnnes ahojnnes merged commit 7d911b1 into main Apr 14, 2024
@ahojnnes ahojnnes deleted the user/joschonb/circular-dep-feature-scene branch April 14, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants