Make VisualIndex::Quantize const to improve readability #2723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
approved these changes
Aug 20, 2024
Contributor
ahojnnes
left a comment
There was a problem hiding this comment.
Thanks, this is indeed a nicer interface.
Contributor
|
@IshitaTakeshi You will need to run |
auto-merge was automatically disabled
August 20, 2024 12:54
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VisualIndex::Quantizeis called from onlyVisualIndex::Buildand modifies the member variablevisual_words_.In the current implementation, we cannot easily guess what
Quantizeactually modifies when reading theBuildfunction.I made the
VisualIndex::Quantizeconst and made it explicitly return the output.