Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ahojnnes
Copy link
Contributor

@ahojnnes ahojnnes commented Oct 24, 2024

  • Resolves some TODOs by adding missing methods, etc.
  • Moves the implementation of various __repr__ to the C++ side.
  • Makes Correspondence a data class to benefit from automatic __copy__ method creation.
  • Makes Database object compatible with context manager interface to enable with pycolmap.Database("path.db") as db usage.
  • Some backwards compatibility breakage to achieve consistent method names in C++ and Python.

Copy link
Contributor

@B1ueber2y B1ueber2y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@ahojnnes ahojnnes requested a review from sarlinpe October 25, 2024 06:13
Copy link
Member

@sarlinpe sarlinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, thanks!

@ahojnnes ahojnnes enabled auto-merge (squash) October 26, 2024 09:26
@ahojnnes ahojnnes merged commit 648856d into main Oct 26, 2024
@ahojnnes ahojnnes deleted the user/jsch/pycolmap-improvements branch October 26, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants