Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve logging for errors in masking during feature extraction #3034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahojnnes merged 13 commits into from
Dec 18, 2024
Merged

Improve logging for errors in masking during feature extraction #3034

ahojnnes merged 13 commits into from
Dec 18, 2024

Conversation

@Ambrosiussen
Copy link
Contributor

@Ambrosiussen Ambrosiussen commented Dec 12, 2024

The Masking logging is quite unhelpful currently.
There is no indication if the mask arguments used in the Feature Extractor are correct, or if a mask for any given image is missing.
This PR helps visualizing this.

ahojnnes
ahojnnes reviewed Dec 12, 2024
View reviewed changes
ahojnnes
ahojnnes reviewed Dec 12, 2024
View reviewed changes
ahojnnes
ahojnnes reviewed Dec 12, 2024
View reviewed changes
ahojnnes
ahojnnes approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@ahojnnes ahojnnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM.

@ahojnnes ahojnnes changed the title Improve Masking Logging Improve logging for errors in masking during feature extraction Dec 12, 2024
@ahojnnes ahojnnes enabled auto-merge (squash) December 12, 2024 11:43
auto-merge was automatically disabled December 12, 2024 11:47

Head branch was pushed to by a user without write access

@ahojnnes
Copy link
Contributor

ahojnnes commented Dec 12, 2024

@Ambrosiussen There seems to be a bug in the logic, see: https://github.com/colmap/colmap/actions/runs/12295764100/job/34313358272?pr=3034

@Ambrosiussen
Copy link
Contributor Author

Ambrosiussen commented Dec 12, 2024

@Ambrosiussen There seems to be a bug in the logic, see: https://github.com/colmap/colmap/actions/runs/12295764100/job/34313358272?pr=3034

I think it actually exposed a bug! If you look at the dataset, and the arguments used for automatic reconstruction. No mask is supposed to be used at all!

Yet somehow it passes this check which was already there :)
if (mask && !options_.mask_path.empty()) {

ubprocess.CalledProcessError: Command '['/home/runner/work/colmap/colmap/build/src/colmap/exe/colmap', 'automatic_reconstructor', '--image_path', 'boulders/images/', '--workspace_path', '/home/runner/work/colmap/colmap/eth3d_benchmark/boulders', '--use_gpu', '1', '--num_threads', '-1', '--quality', 'low', '--camera_model', 'PINHOLE', '--camera_params', '3408.29,3408.61,3115.6,2067.54']'

@ahojnnes
Copy link
Contributor

ahojnnes commented Dec 12, 2024

image_reader.cc:56 needs the following I would guess:

  if (options_.mask_path) {
    options_.mask_path =
        EnsureTrailingSlash(StringReplace(options_.mask_path, "\\", "/"));
  }

@Ambrosiussen
Copy link
Contributor Author

Ambrosiussen commented Dec 18, 2024 •
edited
Loading

@ahojnnes Any idea why these tests dont run? EDIT: And right after I comment this they magically start running :D

@ahojnnes
Copy link
Contributor

ahojnnes commented Dec 18, 2024

They need to be approved by a maintainer for first time contributors.

@ahojnnes ahojnnes merged commit 0a6c915 into colmap:main Dec 18, 2024
16 checks passed
@ahojnnes
Copy link
Contributor

ahojnnes commented Dec 18, 2024

Thank you for your contribution.

HernandoR pushed a commit to HernandoR/colmap that referenced this pull request Dec 30, 2024
@Ambrosiussen @ahojnnes @sarlinpe
Improve logging for errors in masking during feature extraction (colm…
7f79164 
…ap#3034)

The Masking logging is quite unhelpful currently.
There is no indication if the mask arguments used in the Feature
Extractor are correct, or if a mask for any given image is missing.
This PR helps visualizing this.

---------

Co-authored-by: Johannes Schönberger <[email protected]>
Co-authored-by: Paul-Edouard Sarlin <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahojnnes ahojnnes ahojnnes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ambrosiussen @ahojnnes @sarlinpe