Add Rig serialization support to reconstruction+database #3143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B1ueber2y
reviewed
Feb 7, 2025
B1ueber2y
reviewed
Feb 10, 2025
B1ueber2y
reviewed
Feb 10, 2025
B1ueber2y
reviewed
Feb 10, 2025
B1ueber2y
reviewed
Feb 10, 2025
B1ueber2y
reviewed
Feb 10, 2025
B1ueber2y
reviewed
Feb 10, 2025
B1ueber2y
reviewed
Feb 10, 2025
B1ueber2y
reviewed
Feb 10, 2025
|
|
||
| // Note that cameras must be read before images. | ||
|
|
||
| void ReadRigsText(Reconstruction& reconstruction, std::istream& stream); |
Contributor
There was a problem hiding this comment.
We should update the I/O methods in the Reconstruction class as well (e.g. Reconstruction::ReadBinary), where we will write/read rigs when there are any.
Contributor
Author
There was a problem hiding this comment.
I wanted to wait with doing the actual serialization until we reached feature completeness together with frames?
Contributor
|
In the current code the rigs are not used as it is not associated through frames to images. Does it make sense to first add the frames into I/O and merge together? Also, after we fully support the frames I/O some code will be unnecessary (e.g., https://github.com/colmap/colmap/blob/user/jsch/rig-calib-reconstruction/src/colmap/scene/synthetic.cc#L243-L247) |
B1ueber2y
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.