Fix naming of cross covariance and add relative pose covariance interface #3170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
reviewed
Feb 18, 2025
ahojnnes
approved these changes
Feb 18, 2025
Contributor
|
Actually, this is not really a correlation but still a covariance. How about just also GetCamFromWorldCov but with two instead of one image argument? |
Contributor
Author
Indeed, true. How about we say |
Contributor
|
SGTM |
Contributor
Author
|
I added another interface to directly get covariance for multiple images. |
ahojnnes
reviewed
Feb 19, 2025
ahojnnes
reviewed
Feb 19, 2025
ahojnnes
reviewed
Feb 19, 2025
ahojnnes
reviewed
Feb 21, 2025
ahojnnes
reviewed
Feb 21, 2025
ahojnnes
reviewed
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the name is too long. Creating this PR to initiate the thread.