Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ahojnnes
Copy link
Contributor

@ahojnnes ahojnnes commented Apr 7, 2025

Fixing the unrelated issue of correctly initializing the PRNG in our synthetic scene generator revealed issues with homography pose estimation. Out of the 4 decomposed solutions, the cheirality check can only eliminate 2 and we would randomly pick one of them. I added a reprojection check to resolve the ambiguity. This PR addresses both issues jointly. Previously, on synthetically generated image pairs, half of the pairs would fail to correctly estimate the relative pose from the homography. Now, we achieve 100% success rate. I also added more test coverage.

Copy link
Contributor

@B1ueber2y B1ueber2y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

Copy link
Member

@sarlinpe sarlinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@ahojnnes ahojnnes merged commit f4a7e14 into main Apr 7, 2025
14 checks passed
@ahojnnes ahojnnes deleted the user/jsch/two-view-geometry-fixes branch April 7, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants