-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix two-view geometry pose estimation for homography #3250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
commented
Apr 7, 2025
ahojnnes
commented
Apr 7, 2025
ahojnnes
commented
Apr 7, 2025
B1ueber2y
approved these changes
Apr 7, 2025
Contributor
B1ueber2y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM
sarlinpe
approved these changes
Apr 7, 2025
Member
sarlinpe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the unrelated issue of correctly initializing the PRNG in our synthetic scene generator revealed issues with homography pose estimation. Out of the 4 decomposed solutions, the cheirality check can only eliminate 2 and we would randomly pick one of them. I added a reprojection check to resolve the ambiguity. This PR addresses both issues jointly. Previously, on synthetically generated image pairs, half of the pairs would fail to correctly estimate the relative pose from the homography. Now, we achieve 100% success rate. I also added more test coverage.