Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update GetPathBaseName to rely on std::filesystem #3481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarlinpe merged 4 commits into from
Jul 14, 2025
Merged

Update GetPathBaseName to rely on std::filesystem #3481

sarlinpe merged 4 commits into from
Jul 14, 2025

Conversation

@sarlinpe
Copy link
Member

@sarlinpe sarlinpe commented Jul 13, 2025

No description provided.

B1ueber2y
B1ueber2y approved these changes Jul 13, 2025
View reviewed changes
Copy link
Contributor

@B1ueber2y B1ueber2y left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Nit: does it make sense to use the std::filesystem support fs_path.has_filename() instead of basename.empty()? Though it should be equivalent.

@sarlinpe
Copy link
Member Author

sarlinpe commented Jul 14, 2025

Indeed, good catch, thanks.

@sarlinpe sarlinpe marked this pull request as ready for review July 14, 2025 07:09
@sarlinpe sarlinpe merged commit 3bbb1cd into main Jul 14, 2025
14 checks passed
@sarlinpe sarlinpe deleted the sarlinpe/update-GetPathBaseName branch July 14, 2025 07:11
@BrewTestBot BrewTestBot mentioned this pull request Nov 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@B1ueber2y B1ueber2y B1ueber2y approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarlinpe @B1ueber2y