Fix comment for FilterStationaryMatches #3525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
reviewed
Aug 4, 2025
|
|
||
| // Detect if inlier matches are caused by a watermark. | ||
| // A watermark causes a pure translation in the boundaries of the images. | ||
| // Remove matches that are caused by a static watermark, which has the same |
Contributor
There was a problem hiding this comment.
Thanks, this comment was wrongly copied from the previous function... The main purpose for implementing this feature are robotic / data capture platforms with rigidly mounted cameras, where the platform itself is visible in the images and the data is crowd-sourced (i.e., think of mapillary), so we cannot easily generate a mask to ignore the features.
Member
Author
There was a problem hiding this comment.
Got it. It would be nice to unify this with the watermark detector, e.g. make the detection stationary or translation-only and discard matches in both cases.
ahojnnes
approved these changes
Aug 4, 2025
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.