Add explicit tests for fixing gauge freedom and bugfix #3533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarlinpe
approved these changes
Aug 5, 2025
ahojnnes
added a commit
that referenced
this pull request
Aug 5, 2025
No surprise... It turns out that writing a few tests helps with uncovering bugs. This PR adds tests for both gauge fixing options, improves the behavior when some cameras are already fixed, and fixes a bug when points are already fixed (introduced by the recent perf regression fix).
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 19, 2025
No surprise... It turns out that writing a few tests helps with uncovering bugs. This PR adds tests for both gauge fixing options, improves the behavior when some cameras are already fixed, and fixes a bug when points are already fixed (introduced by the recent perf regression fix).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No surprise... It turns out that writing a few tests helps with uncovering bugs. This PR adds tests for both gauge fixing options, improves the behavior when some cameras are already fixed, and fixes a bug when points are already fixed (introduced by the recent perf regression fix).