Change input in cost function to log scale and remove custom manifold from colmap. #3538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Its a bit unfortunate that a release was made 44 minutes ago. We would have to patch another one... |
Contributor
Author
|
Maintaining cibuildtool consistency for the pycolmap and pyceres pypi releases is impractical since we update it a lot. Now that pycolmap 3.12.3, pyceres 2.4, and the heads of the two repos are using three different cibuildtool versions. So we should take action to remove the custom manifold from pycolmap, as it has brought us so much trouble. |
ahojnnes
approved these changes
Aug 5, 2025
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 19, 2025
… from colmap. (colmap#3538) Fixes: colmap#3537 Fixes: colmap#3485 Cherry-picked from colmap#3494 since there were no consensus on changing the Sim3d structure due to numerical stability.
ahojnnes
pushed a commit
that referenced
this pull request
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3537
Fixes: #3485
Cherry-picked from #3494 since there were no consensus on changing the Sim3d structure due to numerical stability.