Add random_seed to IncrementalMapper to control all RANSAC seeds for improved SfM reproducibility #3544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 7, 2025 10:20
ahojnnes
reviewed
Aug 7, 2025
ahojnnes
reviewed
Aug 7, 2025
ahojnnes
reviewed
Aug 7, 2025
src/colmap/exe/sfm.cc
Outdated
| options.AddDefaultOption("gpu_index", &reconstruction_options.gpu_index); | ||
| options.Parse(argc, argv); | ||
|
|
||
| reconstruction_options.random_seed = kDefaultPRNGSeed; |
Contributor
There was a problem hiding this comment.
How about adding a random_seed field to AutomaticReconstructionController::Options and appropriately passing it inside the AutomaticReconstructionController to the respective workers? Then, here we would expose it also as a commandline argument?
Contributor
Author
There was a problem hiding this comment.
Done. To avoid naming conflicts, I renamed the global random_seed in OptionsManager to default_random_seed.
ahojnnes
reviewed
Aug 7, 2025
|
|
||
| ASSERT_EQ(reconstruction_manager0->Size(), 1); | ||
|
|
||
| // Same seed should produce similar results, up to floating-point variations |
Contributor
There was a problem hiding this comment.
If we set num_threads=1, the reconstructions should be identical?
Contributor
Author
There was a problem hiding this comment.
Yes, I added single-threaded tests. Using the same seed and single thread produces identical results.
ahojnnes
reviewed
Aug 8, 2025
ahojnnes
reviewed
Aug 8, 2025
ahojnnes
approved these changes
Aug 8, 2025
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 19, 2025
…improved SfM reproducibility (colmap#3544) This PR introduces a `random_seed` option in IncrementalMapper that controls the random seeds used in all RANSAC processes throughout the reconstruction pipeline. This enhancement improves SfM reproducibility, facilitating debugging and consistent testing. Floating-point variations from Ceres optimization in multithreaded environments remain unavoidable. --------- Co-authored-by: StonerLing <[email protected]> Co-authored-by: Johannes Schönberger <[email protected]>
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 22, 2025
…improved SfM reproducibility (colmap#3544) This PR introduces a `random_seed` option in IncrementalMapper that controls the random seeds used in all RANSAC processes throughout the reconstruction pipeline. This enhancement improves SfM reproducibility, facilitating debugging and consistent testing. Floating-point variations from Ceres optimization in multithreaded environments remain unavoidable. --------- Co-authored-by: StonerLing <[email protected]> Co-authored-by: Johannes Schönberger <[email protected]>
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 22, 2025
…improved SfM reproducibility (colmap#3544) This PR introduces a `random_seed` option in IncrementalMapper that controls the random seeds used in all RANSAC processes throughout the reconstruction pipeline. This enhancement improves SfM reproducibility, facilitating debugging and consistent testing. Floating-point variations from Ceres optimization in multithreaded environments remain unavoidable. --------- Co-authored-by: StonerLing <[email protected]> Co-authored-by: Johannes Schönberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
random_seedoption in IncrementalMapper that controls the random seeds used in all RANSAC processes throughout the reconstruction pipeline. This enhancement improves SfM reproducibility, facilitating debugging and consistent testing.Floating-point variations from Ceres optimization in multithreaded environments remain unavoidable.