Fix build with Boost 1.89.0 #3553
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
tavislocus
pushed a commit
to tavislocus/colmap_6dof
that referenced
this pull request
Aug 19, 2025
In the upcoming Boost 1.89.0 release, the Boost.System stub library introduced back in 1.69[^1] has been removed (boostorg/system@7a495bb), which causes a CMake error. This PR change using OPTIONAL_COMPONENTS is based on upstream comment `https://github.com/boostorg/system/issues/132#issuecomment-3146378680` given that no minimum Boost is mentioned for project. [^1]: https://www.boost.org/doc/libs/1_69_0/libs/system/doc/html/system.html#changes_in_boost_1_69
ahojnnes
pushed a commit
that referenced
this pull request
Aug 22, 2025
In the upcoming Boost 1.89.0 release, the Boost.System stub library introduced back in 1.69[^1] has been removed (boostorg/system@7a495bb), which causes a CMake error. This PR change using OPTIONAL_COMPONENTS is based on upstream comment `https://github.com/boostorg/system/issues/132#issuecomment-3146378680` given that no minimum Boost is mentioned for project. [^1]: https://www.boost.org/doc/libs/1_69_0/libs/system/doc/html/system.html#changes_in_boost_1_69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upcoming Boost 1.89.0 release, the Boost.System stub library introduced back in 1.691 has been removed (boostorg/system@7a495bb), which causes a CMake error.
This PR change using OPTIONAL_COMPONENTS is based on upstream comment
https://github.com/boostorg/system/issues/132#issuecomment-3146378680given that no minimum Boost is mentioned for project.Footnotes
https://www.boost.org/doc/libs/1_69_0/libs/system/doc/html/system.html#changes_in_boost_1_69 ↩