-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Use Qt QSettings to remember last-used paths across file dialogs #3585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks, this seems like a nice improvement. I don't know about QSettings. Where are these settings persisted? |
|
We are using QSettings("Colmap", "UISettings") and Qt uses the native settings location of each platform, so the saved paths are persistent across application restarts: In Windows: In macOS: In Linux: Regards, Víctor |
ahojnnes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your answer. Left a few minor comments, otherwise looks good to me.
…map#3585) Right now, every time Colmap is restarted, all file dialogs start from the default location. This forces the user to browse back to the project or dataset folder again and again, which is annoying. This PR changes that behavior by using Qt QSettings to store the last-used directory for each dialog (open, save, import, export, etc.), with a global fallback. That way, the next time a dialog is opened it will point to the folder the user was previously working in. --------- Co-authored-by: Johannes Schönberger <[email protected]>
Right now, every time Colmap is restarted, all file dialogs start from the default location. This forces the user to browse back to the project or dataset folder again and again, which is annoying.
This PR changes that behavior by using Qt QSettings to store the last-used directory for each dialog (open, save, import, export, etc.), with a global fallback. That way, the next time a dialog is opened it will point to the folder the user was previously working in.