Support both Qt5 and Qt6 #3597
Merged
Support both Qt5 and Qt6 #3597
+103
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
reviewed
Aug 28, 2025
Contributor
ahojnnes
left a comment
There was a problem hiding this comment.
Great, thank you very much. It would probably make sense to test Qt6 in at least one of the CI configurations. For example, we could test Qt6 in Ubuntu 24.04 and Qt5 in Ubuntu 22.04? What do you think?
18 tasks
Contributor
Author
|
@ahojnnes The CI configurations are added and all passed in https://github.com/zhouzq-thu/colmap/actions |
ahojnnes
approved these changes
Aug 29, 2025
B1ueber2y
pushed a commit
that referenced
this pull request
Sep 16, 2025
Co-authored-by: Johannes Schönberger <[email protected]> Co-authored-by: Johannes Schönberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.