Share feature extraction max_image_size option #3600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B1ueber2y
approved these changes
Aug 28, 2025
|
FYI: This change just landed in pycolmap 3.13 and broke our existing tests. Maybe mention this under “breaking changes” in the Changelog? It would've been nice to keep things backwards compatible, at least for a while, ideally with a deprecation warning about upcoming breaking changes in a future version. But I understand that things sometimes (need to) break to make progress. |
Contributor
Author
|
Thanks @cr333 for the feedback. We usually trying to maintain backwards compatibility and here it would have not been possible due to the change to an abstract interface. That being said, we missed to call it out in the change log. Let me know if you need help upgrading. I am less than 1m away :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards the introduction of new feature extractors.