Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Throw exception when the rig configurations of the database and existing reconstruction are inconsistent. #3628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
B1ueber2y merged 11 commits into from
Sep 16, 2025
Merged

Throw exception when the rig configurations of the database and existing reconstruction are inconsistent. #3628

B1ueber2y merged 11 commits into from
Sep 16, 2025

Conversation

@B1ueber2y
Copy link
Contributor

@B1ueber2y B1ueber2y commented Sep 15, 2025 •
edited
Loading

This improves safety at the triangulation and will throw exceptions for all legacy databases that do not go through rig_configurator while corresponding to a rig configured reconstruction.

Note that the current hloc triangulation breaks for reconstruction with non-trivial frames due to legacy database interfaces not updated here: https://github.com/cvg/Hierarchical-Localization/blob/master/hloc/triangulation.py#L29. Will send in a fix later in hloc today.

@B1ueber2y
Copy link
Contributor Author

B1ueber2y commented Sep 15, 2025

also cc: @Phil26AT

@B1ueber2y B1ueber2y changed the title Throw exception when the rig configuration of the database and existing reconstruction is inconsistent. Throw exception when the rig configurations of the database and existing reconstruction are inconsistent. Sep 15, 2025
@sarlinpe
Copy link
Member

sarlinpe commented Sep 15, 2025 •
edited
Loading

Note that the current hloc triangulation breaks

Thank you for flagging this! Alternatively, would it make sense for COLMAP to provide a function to populate the cameras and images of an empty database given a reconstruction?

@B1ueber2y B1ueber2y mentioned this pull request Sep 15, 2025
Merged
@B1ueber2y
Copy link
Contributor Author

B1ueber2y commented Sep 15, 2025

Note that the current hloc triangulation breaks

Thank you for flagging this! Alternatively, would it make sense for COLMAP to provide a function to populate the cameras and images of an empty database given a reconstruction?

After migrating to pycolmap.Database, the implementation of creating an empty database from a reconstruction is extremely straightforward: https://github.com/cvg/Hierarchical-Localization/blob/features/pycolmap_database/hloc/triangulation.py#L28-L44, so I think we do not need this function from COLMAP anymore?

ahojnnes
ahojnnes reviewed Sep 16, 2025
View reviewed changes
ahojnnes
ahojnnes approved these changes Sep 16, 2025
View reviewed changes
@B1ueber2y B1ueber2y merged commit cf25ac9 into colmap:main Sep 16, 2025
13 checks passed
@B1ueber2y B1ueber2y deleted the features/triangulation_safety branch September 16, 2025 18:45
B1ueber2y added a commit that referenced this pull request Sep 16, 2025
@B1ueber2y
Throw exception when the rig configurations of the database and exist…
a56be97 
…ing reconstruction are inconsistent. (#3628)
@BrewTestBot BrewTestBot mentioned this pull request Nov 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahojnnes ahojnnes ahojnnes approved these changes

@sarlinpe sarlinpe Awaiting requested review from sarlinpe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@B1ueber2y @sarlinpe @ahojnnes