Fix broken logic of removing cameras at Reconstruction::TearDown(). #3634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
reviewed
Sep 22, 2025
Dawars
pushed a commit
to Dawars/colmap
that referenced
this pull request
Dec 8, 2025
…olmap#3634) With the new abstraction of rigs and frames, at ``Reconstruction::TearDown()``, the removal of cameras should correspond to the removal of rigs. Otherwise the reconstruction object will be broken after TearDown(). In practice, This PR only fixes corner cases when no associated images are available for a camera in the rig. (cherry picked from commit 3a808c8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new abstraction of rigs and frames, at
Reconstruction::TearDown(), the removal of cameras should correspond to the removal of rigs. Otherwise the reconstruction object will be broken after TearDown().In practice, This PR that only fixes corner cases when no associated images are available for a camera in the rig.