Adjust reconstruction consistency checks #3658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B1ueber2y
approved these changes
Oct 8, 2025
Contributor
B1ueber2y
left a comment
There was a problem hiding this comment.
Nice improvement. Thank you!
Contributor
|
We can do the same update for rigs and cameras. Now that camera needs to be inserted before rig which is with a different order from images and frames. We can switch the order and check if the rig exists and if the camera is in the rig. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hugely inconvenient to require data to already be in the frame when a frame is added to the reconstruction and it broke a bunch of internal code. Instead, I am tightening some of the other checks, where I am now checking that when adding an image, the corresponding frame has the image and the equivalent for the sensors in frames.