[V3] convert nodes_bfl.py to V3 schema #10033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+label: Core |
|
git diff between V1 and V3: |
Kosinkadink
approved these changes
Sep 27, 2025
There was a problem hiding this comment.
Windows unit test fails for unrelated reason that we'll review in the morning. Diff looks okay, there are some differences unrelated to this PR that I am curious about (hidden and output_tooltips) that I can clean up later in the v3 object_info code.
Edit: the unit test stuff got fixed earlier, the tests here ran 20 hours ago. Rerunning now for sanity check and then merging. Will ignore that failure case for the other PRs that got submitted before the unit test fix.
Edit edit: maybe these are new unit test failures? still unrelated to these PRs, so merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes were tested after conversion: