Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[V3] convert nodes_mahiro.py to V3 schema #10070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

[V3] convert nodes_mahiro.py to V3 schema #10070

merged 1 commit into from
Sep 29, 2025

Conversation

bigcat88
Copy link
Contributor

Note: experimental=True must be present in the V3 node definition, as without it, Frontend won't display the [BETA] label.
If we don't set is_experimental=True for V3 nodes in the _for_testing category, we'll lose these [BETA] labels in V3.
In V1 nodes, they simply need to have the _for_testing group, and then the [BETA] label will be displayed.

Git diff:

diff --git a/v3_object_info.json b/master_object_info.json
index bf93d28..c2d91f9 100644
--- a/v3_object_info.json
+++ b/master_object_info.json
@@ -20898,8 +20898,7 @@
         "input": {
             "required": {
                 "model": [
-                    "MODEL",
-                    {}
+                    "MODEL"
                 ]
             }
         },
@@ -20917,18 +20916,12 @@
         "output_name": [
             "patched_model"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "Mahiro",
         "display_name": "Mahiro is so cute that she deserves a better guidance function!! (\u3002\u30fb\u03c9\u30fb\u3002)",
         "description": "Modify the guidance to scale more on the 'direction' of the positive prompt rather than the difference between the negative prompt.",
         "python_module": "comfy_extras.nodes_mahiro",
         "category": "_for_testing",
-        "output_node": false,
-        "deprecated": false,
-        "experimental": true,
-        "api_node": false
+        "output_node": false
     },
     "EmptyLTXVLatentVideo": {
         "input": {

@bigcat88
Copy link
Contributor Author

+label: Core

@comfy-pr-bot comfy-pr-bot added the Core Core team dependency label Sep 28, 2025
@Kosinkadink
Copy link
Collaborator

Kosinkadink commented Sep 29, 2025 •
edited
Loading

Gotcha, I'll look into bringing '_for_testing' category functionality into V3.

@bigcat88
Copy link
Contributor Author

just a note: we already merged the V3 nodes(CLIPTextEncodeControlnet, FreSca, UNetSelfAttentionMultiply and other) where we added is_experimental=True to the _for_testing group

@Kosinkadink
Copy link
Collaborator

ah, gotcha. the explicit behavior is probably better, so this should be fine.

Kosinkadink
Kosinkadink approved these changes Sep 29, 2025
View reviewed changes
Copy link
Collaborator

@Kosinkadink Kosinkadink left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at some point we should probably discuss if we should rename this node to just "Mahiro CFG" to not fully erase its identity while making the name length reasonable, but that is beyond the scope of this PR. diff looks good, merging

@Kosinkadink Kosinkadink merged commit 8accf50 into comfyanonymous:master Sep 29, 2025
11 checks passed
@yoland68
Copy link
Collaborator

"Mahiro is so cute that she deserves a better guidance function" ugh, was hoping thsis would have been refactored out

@yoinked-h
Copy link
Contributor

at some point we should probably discuss if we should rename this node to just "Mahiro CFG" to not fully erase its identity while making the name length reasonable, but that is beyond the scope of this PR. diff looks good, merging

and

"Mahiro is so cute that she deserves a better guidance function" ugh, was hoping thsis would have been refactored out

you cant just delete mahiro's identity!!!! ヾ(≧へ≦)〃

in all seriousness it is somewhat of a long node name, if it had to change, then id suggest something like Mahiro Guidance (。・ω・。) or Mahiro CFG (。・ω・。), removing the face removes some of the fun and humor of it [out of scope of this PR but am able to discuss this if it does come to happen]

@bigcat88 bigcat88 deleted the v3/nodes_mahiro branch September 30, 2025 07:27
@quanzs538 quanzs538 mentioned this pull request Oct 3, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kosinkadink Kosinkadink Kosinkadink approved these changes

Assignees
No one assigned
Labels
Core Core team dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bigcat88 @Kosinkadink @yoland68 @yoinked-h @comfy-pr-bot