Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[V3] convert nodes_morphology.py to V3 schema #10159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

[V3] convert nodes_morphology.py to V3 schema #10159

merged 1 commit into from
Oct 2, 2025
+70 −46

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Oct 2, 2025

Nodes were tested after conversion:

Screenshot From 2025-10-02 16-35-38

Git diff:

diff --git a/v3_object_info.json b/master_object_info.json
index 35fd591..10c374f 100644
--- a/v3_object_info.json
+++ b/master_object_info.json
@@ -11262,23 +11262,18 @@
         "input": {
             "required": {
                 "image": [
-                    "IMAGE",
-                    {}
+                    "IMAGE"
                 ],
                 "operation": [
-                    "COMBO",
-                    {
-                        "multiselect": false,
-                        "options": [
-                            "erode",
-                            "dilate",
-                            "open",
-                            "close",
-                            "gradient",
-                            "bottom_hat",
-                            "top_hat"
-                        ]
-                    }
+                    [
+                        "erode",
+                        "dilate",
+                        "open",
+                        "close",
+                        "gradient",
+                        "bottom_hat",
+                        "top_hat"
+                    ]
                 ],
                 "kernel_size": [
                     "INT",
@@ -11307,25 +11302,18 @@
         "output_name": [
             "IMAGE"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "Morphology",
         "display_name": "ImageMorphology",
         "description": "",
         "python_module": "comfy_extras.nodes_morphology",
         "category": "image/postprocessing",
-        "output_node": false,
-        "deprecated": false,
-        "experimental": false,
-        "api_node": false
+        "output_node": false
     },
     "ImageRGBToYUV": {
         "input": {
             "required": {
                 "image": [
-                    "IMAGE",
-                    {}
+                    "IMAGE"
                 ]
             }
         },
@@ -11349,35 +11337,24 @@
             "U",
             "V"
         ],
-        "output_tooltips": [
-            null,
-            null,
-            null
-        ],
         "name": "ImageRGBToYUV",
-        "display_name": null,
+        "display_name": "ImageRGBToYUV",
         "description": "",
         "python_module": "comfy_extras.nodes_morphology",
         "category": "image/batch",
-        "output_node": false,
-        "deprecated": false,
-        "experimental": false,
-        "api_node": false
+        "output_node": false
     },
     "ImageYUVToRGB": {
         "input": {
             "required": {
                 "Y": [
-                    "IMAGE",
-                    {}
+                    "IMAGE"
                 ],
                 "U": [
-                    "IMAGE",
-                    {}
+                    "IMAGE"
                 ],
                 "V": [
-                    "IMAGE",
-                    {}
+                    "IMAGE"
                 ]
             }
         },
@@ -11397,18 +11374,12 @@
         "output_name": [
             "IMAGE"
         ],
-        "output_tooltips": [
-            null
-        ],
         "name": "ImageYUVToRGB",
-        "display_name": null,
+        "display_name": "ImageYUVToRGB",
         "description": "",
         "python_module": "comfy_extras.nodes_morphology",
         "category": "image/batch",
-        "output_node": false,
-        "deprecated": false,
-        "experimental": false,
-        "api_node": false
+        "output_node": false
     },
     "StableCascade_EmptyLatentImage": {
         "input": {

@bigcat88 bigcat88 requested a review from Kosinkadink as a code owner October 2, 2025 13:37
@bigcat88
Copy link
Contributor Author

bigcat88 commented Oct 2, 2025

+label: Core

@comfy-pr-bot comfy-pr-bot added the Core Core team dependency label Oct 2, 2025
Kosinkadink
Kosinkadink approved these changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@Kosinkadink Kosinkadink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff + core looks good, merging

@Kosinkadink Kosinkadink merged commit 8f4ee99 into comfyanonymous:master Oct 2, 2025
11 checks passed
@quanzs538 quanzs538 mentioned this pull request Oct 3, 2025
Open
1 task
@ramon7879 ramon7879 mentioned this pull request Oct 5, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kosinkadink Kosinkadink Kosinkadink approved these changes

Assignees
No one assigned
Labels
Core Core team dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigcat88 @Kosinkadink @comfy-pr-bot