Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[V3] update example_node.py to use V3 schema #9723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

[V3] update example_node.py to use V3 schema #9723

merged 1 commit into from
Oct 2, 2025
+69 −94

Conversation

bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Sep 4, 2025

No description provided.

@bigcat88 bigcat88 changed the title update example_node.py to use V3 schema [V3] update example_node.py to use V3 schema Sep 4, 2025
@Kosinkadink Kosinkadink added the Core Core team dependency label Sep 15, 2025
@Kosinkadink Kosinkadink self-requested a review September 28, 2025 03:09
@Kosinkadink
Copy link
Collaborator

I think it would be better to just have this PR directly replicate the original v1 node. We can add to it later, but we should keep it simple for now.

@bigcat88 bigcat88 force-pushed the v3/update-node-example branch 2 times, most recently from 563405d to 62dffe9 Compare September 30, 2025 12:54
@bigcat88 bigcat88 force-pushed the v3/update-node-example branch from 62dffe9 to 507b119 Compare September 30, 2025 12:57
@bigcat88
Copy link
Contributor Author

I think it would be better to just have this PR directly replicate the original v1 node. We can add to it later, but we should keep it simple for now.

Done

Kosinkadink
Kosinkadink approved these changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@Kosinkadink Kosinkadink left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Only just now noticed the update. Merging.

@Kosinkadink Kosinkadink merged commit 1395bce into comfyanonymous:master Oct 2, 2025
9 checks passed
@quanzs538 quanzs538 mentioned this pull request Oct 3, 2025
Open
1 task
@ramon7879 ramon7879 mentioned this pull request Oct 5, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kosinkadink Kosinkadink Kosinkadink approved these changes

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous

Assignees
No one assigned
Labels
Core Core team dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigcat88 @Kosinkadink