four ui: edge shadows#37239
Merged
Merged
Conversation
Adds a black gradient falloff shadow (20x240, 100%→0% opacity) on the left and right edges of horizontal Scroller panels. Enabled via an opt-in `edge_shadows` parameter on Scroller for easy per-screen control. Enabled on: settings menu, toggles, network, device, developer. Not enabled on: home screen carousel, vertical scrollers, setup screens. Co-authored-by: Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
Contributor
UI Previewmici: |
Collaborator
|
is it less bools if you flip the edge shadows condition, so you only set it false on the homescreen? |
FrogAi
pushed a commit
to FrogAi/FrogPilot
that referenced
this pull request
Apr 2, 2026
* ui: add edge shadow effect to horizontal scrollers in settings Adds a black gradient falloff shadow (20x240, 100%→0% opacity) on the left and right edges of horizontal Scroller panels. Enabled via an opt-in `edge_shadows` parameter on Scroller for easy per-screen control. Enabled on: settings menu, toggles, network, device, developer. Not enabled on: home screen carousel, vertical scrollers, setup screens. Co-authored-by: Cursor <[email protected]> * ui: reduce edge shadow opacity to 80% Co-authored-by: Cursor <[email protected]> * what on earth is this * some lines are ok --------- Co-authored-by: Cursor <[email protected]> Co-authored-by: Shane Smiskol <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds edge shadows to horizontal scrollers, shadows from 0-80% opacity black. Adds a toggle as well, so some scrollers like homescreen stay unaffected (looking to get rid of the need for toggle in the future). Notably, scroll indicator renders above edge shadows; this is intentional