ui: move shake into BigButton#37364
Merged
Merged
Conversation
Contributor
UI Previewmici: Videos are identical! View Diff Report |
Collaborator
Author
|
why didn't ty/ruff detect missing function :( |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the shake animation functionality from the WifiButton class into the base BigButton class, making it reusable for all button types that inherit from BigButton.
Changes:
- Moved shake animation logic (trigger, offset calculation, and position override) from
WifiButtontoBigButton - Added
mathimport tobutton.pyfor the shake offset calculation - Updated
WifiButton.set_wrong_password()to call the newtrigger_shake()method
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| selfdrive/ui/mici/widgets/button.py | Added shake animation functionality to BigButton class including trigger_shake() method, _shake_offset property, and set_position() override |
| selfdrive/ui/mici/layouts/settings/network/wifi_ui.py | Removed duplicate shake implementation from WifiButton and updated to use inherited trigger_shake() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FrogAi
pushed a commit
to FrogAi/FrogPilot
that referenced
this pull request
Apr 3, 2026
* move * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split from #37264