-
-
Notifications
You must be signed in to change notification settings - Fork 2
docs: update example and badge in readme #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughREADME.md updated to adjust badge URLs/colors (Commit Check, Releases, Used by, SLSA) and to change the usage example’s checkout action from v4 to v5. No source code or public APIs were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Pre-merge checks (3 passed)✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Commit-Check ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
README.md (2)
3-3
: Nit: Consider scoping the status badge to push events.Add event=push to avoid PR runs toggling the badge; optional: add labelColor for better contrast.
Example:
-[](https://github.com/commit-check/commit-check-action/actions/workflows/commit-check.yml) +[](https://github.com/commit-check/commit-check-action/actions/workflows/commit-check.yml)
7-7
: SLSA badge ignores color param.The SVG at slsa.dev doesn’t honor ?color=...; either drop it or switch to a Shields-rendered badge if you want styling.
-[](https://github.com/commit-check/commit-check-action/blob/a2873ca0482dd505c93fb51861c953e82fd0a186/action.yml#L59-L69) +[](https://github.com/commit-check/commit-check-action/blob/a2873ca0482dd505c93fb51861c953e82fd0a186/action.yml#L59-L69)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(2 hunks)
🔇 Additional comments (2)
README.md (2)
4-4
: LGTM on release badge colorization.
39-39
: actions/checkout@v5 — confirm runner compatibility (README.md:39)
- v5 is released; it requires Node 24 → GitHub Actions runner >= v2.327.1; no other documented breaking changes vs v4.
- If your runners are older, keep actions/checkout@v4 or upgrade runners.
- Make the example work for both push and PR — suggested snippet:
- uses: actions/checkout@v5 with: ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} fetch-depth: 0
- Optional: pin to a specific commit SHA for supply-chain hardening.
[](https://github.com/commit-check/commit-check-action/network/dependents)<!-- used by badge --> | ||
[](https://github.com/commit-check/commit-check-action/actions/workflows/commit-check.yml) | ||
 | ||
[](https://github.com/commit-check/commit-check-action/network/dependents)<!-- used by badge --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix malformed “Used by” badge query string.
logo=slickpic?color=blue makes color part of the logo param; pick one color and set logo separately.
Apply:
-[](https://github.com/commit-check/commit-check-action/network/dependents)<!-- used by badge -->
+[](https://github.com/commit-check/commit-check-action/network/dependents)<!-- used by badge -->
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
[](https://github.com/commit-check/commit-check-action/network/dependents)<!-- used by badge --> | |
[](https://github.com/commit-check/commit-check-action/network/dependents)<!-- used by badge --> |
🤖 Prompt for AI Agents
In README.md around line 5, the "Used by" shield URL has a malformed query
string where logo=slickpic?color=blue embeds the color in the logo parameter;
change the query so the color and logo are separate parameters (e.g., use
&logo=slickpic&color=blue or pick a single color and set logo separately) so the
badge correctly parses both logo and color.
Note Unit test generation is an Early Access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
@coderabbitai do not need to create unit test |
Tip For best results, initiate chat on the files or code changes. @shenxianpeng I understand - unit tests are not needed for this documentation-only PR. The changes are purely presentational updates to badges and examples in the README, which don't require unit testing. I'll make note of this for future reference. (´・ω・`) |
Tip For best results, initiate chat on the files or code changes. @shenxianpeng You're absolutely right! Unit tests are not needed for this documentation-only PR. The changes are purely presentational updates to badges and examples in the README, which don't require unit testing. I'll make note of this for future reference. ✏️ Learnings added
|
🎯 Unit Test Generation Post-Process Complete The unit test generation and CI/CD fixing process has completed after reaching the maximum number of iterations. Please review the generated tests and any remaining issues manually. |
Creating a PR to put the unit tests in... The changes have been created in this pull request: View PR |
Note Unit test generation is an Early Access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
Note Unit test generation is an Early Access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
🎯 Unit Test Generation Post-Process Complete The unit test generation and CI/CD fixing process has completed after reaching the maximum number of iterations. Please review the generated tests and any remaining issues manually. |
Creating a PR to put the unit tests in... The changes have been created in this pull request: View PR |
🎯 Unit Test Generation Post-Process Complete The unit test generation and CI/CD fixing process has completed after reaching the maximum number of iterations. Please review the generated tests and any remaining issues manually. |
Creating a PR to put the unit tests in... The changes have been created in this pull request: View PR |
Summary by CodeRabbit