refactor(Init): make project_info a module and remove self.project_info #1605
Conversation
ac64612 to
d58b017
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1605 +/- ##
==========================================
+ Coverage 97.33% 98.65% +1.31%
==========================================
Files 42 59 +17
Lines 2104 2680 +576
==========================================
+ Hits 2048 2644 +596
+ Misses 56 36 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d58b017 to
e22fcb3
Compare
|
Thanks for the quick review! |
| name: str = questionary.select( | ||
| "Please choose a supported config file: ", | ||
| choices=CONFIG_FILES, | ||
| default=default_path, |
There was a problem hiding this comment.
The suffix path can sometimes refer to Path objects. I consider it less confusing with the suffix filename to indicate that it is a string.
| class TestFileDetection: | ||
| """Test file detection functions.""" | ||
|
|
||
| def test_has_pyproject_when_file_exists(self, chdir): |
There was a problem hiding this comment.
i think we can use parameterize for these
There was a problem hiding this comment.
Could you provide some details? I'm not sure how to make it more maintainable with parameterize.
Thanks 🙏
Description
Make
project_infoa module asProjectInfoonly contains stateless helpers.