Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add smallpt example notebook running through xeus-cpp-lite #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anutosh491
Copy link
Collaborator

Description

Refer #235 (comment)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@anutosh491
Copy link
Collaborator Author

cc @kr-2003 , could you please verify the working of the smallpt example for me ?

It is 2 min process (so have add some logs so that the user doesn't feel lost)

You should be seeing this

image

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (3c5328d) to head (08bee31).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kr-2003
Copy link
Contributor

kr-2003 commented May 13, 2025

@anutosh491
I have checked the smallpt notebook. Its working fine.

Screenshot 2025-05-13 at 5 50 22 PM

@mcbarton
Copy link
Collaborator

Is there a reason this example is a completely separate notebook, and the examples is not added to the already existing notebook?

@mcbarton
Copy link
Collaborator

mcbarton commented May 13, 2025

If there is a legitimate reason to have it as a separate notebook, then the notebook needs to be uploaded to the deployment here https://github.com/anutosh491/xeus-cpp/blob/9628b1c132d23833b25ee08166c1ee2f71f3205e/.github/workflows/deploy-github-page.yml#L76

Copy link
Collaborator

@mcbarton mcbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example either needs integrating with existing notebook (if no legitimate reason to be separate), or new notebook added to deployment.

@SylvainCorlay
Copy link
Collaborator

the notebook needs to be uploaded to the deployment here

Good catch!

I think it makes sense for it to be in a separate notebook. The main notebook displays the basic features of the kernel, and this notebook shows a more advanced usecase.

@anutosh491
Copy link
Collaborator Author

Good catch!

I think it makes sense for it to be in a separate notebook. The main notebook displays the basic features of the kernel, and this notebook shows a more advanced usecase.

Addressed !

@SylvainCorlay
Copy link
Collaborator

This looks good to me! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants