-
Notifications
You must be signed in to change notification settings - Fork 36
Add smallpt example notebook running through xeus-cpp-lite #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cc @kr-2003 , could you please verify the working of the smallpt example for me ? It is 2 min process (so have add some logs so that the user doesn't feel lost) You should be seeing this |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 20 20
Lines 950 950
Branches 87 87
=======================================
Hits 777 777
Misses 173 173 🚀 New features to boost your workflow:
|
@anutosh491 ![]() |
Is there a reason this example is a completely separate notebook, and the examples is not added to the already existing notebook? |
If there is a legitimate reason to have it as a separate notebook, then the notebook needs to be uploaded to the deployment here https://github.com/anutosh491/xeus-cpp/blob/9628b1c132d23833b25ee08166c1ee2f71f3205e/.github/workflows/deploy-github-page.yml#L76 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example either needs integrating with existing notebook (if no legitimate reason to be separate), or new notebook added to deployment.
Good catch! I think it makes sense for it to be in a separate notebook. The main notebook displays the basic features of the kernel, and this notebook shows a more advanced usecase. |
Addressed ! |
This looks good to me! Thanks! |
Description
Refer #235 (comment)
Type of change
Please tick all options which are relevant.