fix(driver,stub): allow creation#705
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request modifies the stub driver implementation in compio-driver to allow driver creation and no-op operation execution instead of immediately failing. The stub driver is used on Linux systems when neither the io-uring nor polling features are enabled, which is an unusual configuration that triggers compile warnings.
Changes:
- Modified
Driver::new()to returnOk(Self(()))instead of an error - Changed multiple driver methods (
attach,cancel,push,poll,release_buffer_pool) to return success or no-op instead of errors/panics - Simplified the
cancelmethod to do nothing instead of callingstub_unimpl()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Berrysoft
reviewed
Feb 22, 2026
Berrysoft
requested changes
Feb 22, 2026
Member
Berrysoft
left a comment
There was a problem hiding this comment.
Sorry, but after a rethinking, I prefer Err for push().
463376d to
e1b9372
Compare
Member
Author
Done |
Berrysoft
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.