Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(io): make also bytes method on AsyncReadExt/AsyncWriteExt feature gated#766

Merged
George-Miao merged 2 commits into
compio-rs:masterfrom
ararog:master
Mar 11, 2026
Merged

fix(io): make also bytes method on AsyncReadExt/AsyncWriteExt feature gated#766
George-Miao merged 2 commits into
compio-rs:masterfrom
ararog:master

Conversation

@ararog
Copy link
Copy Markdown
Contributor

@ararog ararog commented Mar 11, 2026

No description provided.

@ararog ararog marked this pull request as ready for review March 11, 2026 18:55
Copy link
Copy Markdown
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ararog
Copy link
Copy Markdown
Contributor Author

ararog commented Mar 11, 2026

@George-Miao there are some edge cases to cover, only AsyncReadAt is implemented by File and Stream implementation of Framed has AsyncRead as constraint.

@George-Miao
Copy link
Copy Markdown
Member

@George-Miao there are some edge cases to cover, only AsyncReadAt is implemented by File and Stream implementation of Framed has AsyncRead as constraint.

Right. Use std::io::Cursor to wrap any AsyncReadAt gives you AsyncRead.

@George-Miao George-Miao merged commit b5ec94a into compio-rs:master Mar 11, 2026
66 of 67 checks passed
@George-Miao George-Miao added bug Something isn't working package: io Related to compio-io labels Mar 11, 2026
@github-actions github-actions Bot mentioned this pull request Mar 11, 2026
This was referenced Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package: io Related to compio-io

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants