refactor(net): adjust send* methods#770
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
|
@Berrysoft do you mind merging this so I can do the downstream patch in H2? |
Member
Author
|
Needs reviewing :( |
Closed
fantix
added a commit
to compio-rs/compio-ktls
that referenced
this pull request
Apr 26, 2026
The `app-write-with-empty-ancillary` feature is no longer necessary because compio-rs/compio#770 recovered the non-zero-copy behaviors of `TcpStream::write` and `TcpStream::write_vectored`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSG_NOSIGNALfor allsend*methods. This aligns with std.send_zerocopyin<TcpStream as AsyncWrite>::write. The Linux zerocopy is not always efficient. It is recommended for >10KB buffers.UnixStream::send_zerocopyandUdpSocket::send_zerocopy.flagparam insend_zerocopy.