feat(signal,dispatcher)!: remove signalfd#794
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the Linux-specific signalfd-based signal handling backend so Linux uses the same process-wide signal handler approach as other Unix platforms.
Changes:
- Delete the Linux-only
signalfdimplementation (compio-signal/src/linux.rs). - Remove the Linux
#[cfg_attr(..., path = "linux.rs")]module override socompio-signal::unixis used on Linux too. - Simplify/realign
compio-signaldependencies by removing Linux-only deps and making the shared deps unconditional.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| compio-signal/src/linux.rs | Deletes the Linux signalfd listener implementation. |
| compio-signal/src/lib.rs | Routes Linux to the generic unix backend by removing the Linux path override. |
| compio-signal/Cargo.toml | Removes Linux-only dependencies and promotes shared deps (once_cell, slab, synchrony) to unconditional deps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Is signal masking no longer a concern for dispatcher? |
Member
Author
|
If we handle the signals process-wide, the signal masks are useless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As other platforms all set signal handlers process-wide, we should remove the signalfd impls.
cc: @ortuman
I think we can then remove the special flag
block_signalsin compio-dispatcher?