refactor(net)!: add TcpSocket & UnixSocket#817
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors compio-net socket configuration APIs by introducing TcpSocket and UnixSocket and removing the shared SocketOpts builder, updating downstream usage accordingly.
Changes:
- Added
TcpSocketandUnixSockettypes to configure sockets prior toconnect()/listen(). - Removed
SocketOptsand simplifiedTcpListener/UnixListener/UdpSocketconstructors to use fixed defaults. - Updated
compio-wsTLS connection setup andcompio-netTCP connect tests to the new APIs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| compio-ws/src/tls.rs | Updates WebSocket TLS connect path to use TcpStream::connect and sets TCP_NODELAY post-connect. |
| compio-net/src/tcp.rs | Removes SocketOpts plumbing, adds TcpSocket, and adds several socket option accessors. |
| compio-net/src/unix.rs | Removes SocketOpts plumbing, adds UnixSocket, and adds take_error helpers. |
| compio-net/src/udp.rs | Removes SocketOpts from UDP bind path. |
| compio-net/src/opts.rs | Deletes the SocketOpts implementation. |
| compio-net/src/lib.rs | Removes the opts module and SocketOpts re-export. |
| compio-net/tests/tcp_connect.rs | Updates bind-and-connect test to use TcpSocket APIs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Add some document on |
d6b9b63 to
7106f67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
TcpSocket&UnixSocket, and removesSocketOpts. The APIs and basicly the same as tokio, without some deprecated ones.