feat(driver,iour): allow to specify cqsize#834
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurability for the io_uring completion queue size via ProactorBuilder, and updates io_uring initialization to apply the configured CQ size and force the NOFORK (dontfork) setup flag.
Changes:
- Add
cqsize: Option<u32>toProactorBuilderplus acqsize()setter. - Apply
setup_cqsize()during io_uring driver initialization when configured. - Always set
dontfork()on the io_uring builder.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
compio-driver/src/lib.rs |
Extends ProactorBuilder with a CQ size option and exposes it via a public builder method. |
compio-driver/src/sys/iour/mod.rs |
Wires the new builder option into io_uring setup and enforces dontfork() during ring creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #783
Also force
dontforkbecause we always don't share resources across forks in Rust. All other resources are created withCLOEXEC.