Installer: Initialize $nameMatchesRequiredPackage#7932
Merged
Conversation
Member
|
That makes sense but please rebase on 1.8 branch for bugfixes |
Contributor
Author
|
Sorry, will do. |
Contributor
Author
|
So that change did make stuff worse, sorry. Give me a few minutes :-) |
We had a case where we got `Undefined variable: nameMatchesRequiredPackage` — I think it should be initialized with false, right?
Contributor
|
you should not only change the target branch of the PR. You also need to rebase your feature branch so that it is based on 1.8 rather than master and to force-push the branch to your github fork. |
Contributor
Author
|
Think I did it now :-) |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a case where we got
Undefined variable: nameMatchesRequiredPackage— I think it should be initialized with false, right?I am currently not able to create a reproduction case - if you need one before merging, please let me know and I will do my best. But just from looking at the code, I think it can happen that the variable is undefined.