fix: reserve shutdown time for required cleanup - #581

@richardfogaca is attempting to deploy a commit to the Compozy Team on Vercel.

A member of the Team first needs to authorize it.

No actionable comments were generated in the recent review. 🎉

Walkthrough

The checkpoint summary runtime now checks cancellation before fetching work and reserves shutdown time for required provider cleanup. New tests verify bounded shutdown behavior. Other tests use typed cancellation and updated offload expectations.

Changes

Checkpoint summary shutdown

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to c7820

Daemon shutdown now bounds optional checkpoint-summary work so required cleanup retains time, while queued optional summaries are skipped after the drain deadline. No current merge-blocking risk remains.

Sequence Diagram(s)

sequenceDiagram
  participant checkpointMemoryShutdowner
  participant checkpointSummaryRuntime
  participant MemoryProvider
  checkpointMemoryShutdowner->>checkpointSummaryRuntime: Shutdown with earlier runtime deadline
  checkpointSummaryRuntime-->>checkpointMemoryShutdowner: Stop worker and join runtime.done
  checkpointMemoryShutdowner->>MemoryProvider: Shutdown with remaining context

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands.}

Confidence Score: 5/5

The PR appears safe to merge, with no actionable new issue introduced since the previous review.

The only changes since the previous review reorder existing option declarations and configuration properties without changing behavior, and the current shutdown implementation preserves the original context for required cleanup while bounding optional summary work.

sequenceDiagram
    participant D as Daemon shutdown
    participant W as Summary worker
    participant C as Active summary child
    participant P as Memory provider
    participant R as Required resources

    D->>W: Shutdown with reserved early deadline
    W->>C: Cancel active optional work
    W->>W: Skip queued summaries after cancellation
    W-->>D: Worker joined
    D->>P: Shutdown with original live context
    D->>R: Close within remaining budget
    R-->>D: Cleanup complete

_{Reviews (3): Last reviewed commit: "test: align memory fixture wiring with u..." | Re-trigger Greptile}

Strengthened the cancellation-error assertion and fixed the failing Knowledge browser journey: it now explicitly enables memory after the opt-in default change and resolves portaled dialogs outside the window. The complete create/edit/revert/search/recall/delete journey passes with the shared fixture correction; make gate passes, including daemon race tests and 7,106 web tests.

The requeue suggestion is not applied: shutdown intentionally abandons optional checkpoint backlog after its drain deadline; requeueing an in-memory job does not make it survive a daemon restart. Primary transcripts remain authoritative, and the existing shutdown regression verifies cancellation, worker joining, and live required-cleanup context. Preview authorization remains a team-owned blocker.

Aligned the shared memory fixture declarations and wiring with main, eliminating the duplicate key introduced by overlapping additions in the PR merge. The final make gate passes; the verified behavioral fixes and browser regressions are unchanged.

CI is green on 66254d7bb8573a08e224144064a673cc58cdd571, including all browser shards, runtime, desktop, frontend, and backend verification. All review threads are resolved. Preview deployment remains separately awaiting team authorization.