Thanks to visit codestin.com
Credit goes to github.com

Skip to content

sanitize MPL figure size #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bnavigator
Copy link
Contributor

The default figure size is not hardcoded anymore since matplotlib-inline 0.1.5 (ipython/matplotlib-inline#14), so we need to sanitize for the tests.

@bnavigator
Copy link
Contributor Author

[   96s] =================================== FAILURES ===================================
[   96s] _____________________ tests/sample_notebook.ipynb::Cell 9 ______________________
[   96s] Notebook cell execution failed
[   96s] Cell 9: Cell outputs differ
[   96s] 
[   96s] Input:
[   96s] %matplotlib inline
[   96s] import matplotlib.pyplot as plt
[   96s] plt.plot([1, 2, 3, 4, 5], [1, 3, 2, 2.5, 1.5], 'o-', label='graph')
[   96s] plt.xlabel('x')
[   96s] plt.ylabel('y')
[   96s] plt.title('Simple plot')
[   96s] plt.legend(loc='best')
[   96s] 
[   96s] Traceback:
[   96s]  mismatch 'text/plain'
[   96s] 
[   96s]  assert reference_output == test_output failed:
[   96s] 
[   96s]   '<Figure size... with 1 Axes>' == '<Figure size... with 1 Axes>'
[   96s]   - <Figure size 640x480 with 1 Axes>
[   96s]   ?              - ^ ^ ^
[   96s]   + <Figure size 432x288 with 1 Axes>
[   96s]   ?               ^^ ^ ^
[   96s] 
[   96s] =============================== warnings summary ===============================

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Aug 21, 2022
https://build.opensuse.org/request/show/998389
by user bnavigator + dimstar_suse
- Remove python36 skiptest code
- Add nbval-sanitize-figure-size.patch
  * gh#computationalmodelling/nbval#183

- Multibuild test flavor: avoid (possible) build cycle (forwarded request 998388 from bnavigator)
fangohr added a commit that referenced this pull request Sep 10, 2022
CI: Various minor improvements to fix CI

includes contribution from @bnavigator in #183
@fangohr
Copy link
Member

fangohr commented Sep 10, 2022

Contribution included in #186 - Thank you!

@fangohr fangohr closed this Sep 10, 2022
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Oct 28, 2022
See: computationalmodelling/nbval#183

git-svn-id: file:///srv/repos/svn-community/svn@1338430 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Oct 28, 2022
See: computationalmodelling/nbval#183



git-svn-id: file:///srv/repos/svn-community/svn@1338430 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants