Fix/file version event dispatch#12896
Open
m-kreis wants to merge 3 commits into
Open
Conversation
aembler
requested changes
May 6, 2026
Member
aembler
left a comment
There was a problem hiding this comment.
getVersionToModify is not the appropriate place for this. The method's purpose is to get a new file version, but only if conditions allow it (e.g. the person working on the file is different that then previous version, or if the file version is older than a particular timestamp threshold.) The prefix and new file name do not belong here, and swapping method arguments isn't something we should do.
This should be done in a different way, without modifying this file and changing its arguments.
d0ff6c7 to
11f34af
Compare
Author
|
I don't think it can be done without modifying getVersionToModify(), as duplicate() followed by approve() will always trigger on_file_version_approve with inconsistent data. Proposing this:
|
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on_file_version_deleteon_file_version_approveIf I swap a file in the file manager, a new version is created in the
save()method ofconcrete/src/File/Import/FileImporter.php. In there thegetVersionToModify()executesduplicate()on the existing file version and thenapprove()on the duplicated file version (concrete/src/Entity/File/Version.php). Inapprove()the eventon_file_version_approveis fired. But unlessupdateFile()is called, the duplicated file has the old name and prefix but already the new file version id. This leads to a file version passed to the event with inconsistent data. So I movedupdateFile()togetVersionToModify()betweenduplicate()andapprove(). ForupdateFile()I need the new file name and the prefix. As the only call togetVersionToModify()which requests aforceCreateNewis from the file importer the impact of the change seemed reasonably small.