Add Microsoft Terminal profile shortcut #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimergp
reviewed
May 6, 2024
jaimergp
reviewed
May 6, 2024
jaimergp
reviewed
May 6, 2024
jaimergp
reviewed
May 6, 2024
Co-authored-by: jaimergp <[email protected]>
jaimergp
reviewed
May 8, 2024
jaimergp
reviewed
May 8, 2024
jaimergp
reviewed
May 8, 2024
jaimergp
reviewed
May 8, 2024
jaimergp
reviewed
May 8, 2024
jaimergp
reviewed
May 10, 2024
jaimergp
reviewed
May 10, 2024
jaimergp
reviewed
May 15, 2024
jaimergp
previously approved these changes
May 15, 2024
Contributor
jaimergp
left a comment
There was a problem hiding this comment.
LGTM. Feel free to merge once you are ready!
If you have a screenshot of how it looks like on Windows, I think it would be nice to have it posted here. If it's too much trouble, no worries.
Co-authored-by: jaimergp <[email protected]>
Contributor
Author
I will create one and post it before I merge. |
jaimergp
approved these changes
May 15, 2024
Contributor
Author
|
Here is a menu file to create the git bash terminal profile and the screenshot shows how it look like in the Windows Terminal. {
"$schema": "https://json-schema.org/draft-07/schema",
"$id": "https://schemas.conda.io/menuinst-1.schema.json",
"menu_name": "git bash",
"menu_items": [
{
"name": "git bash",
"command": [
"C:\\Program Files\\Git\\bin\\bash.exe",
"-li"
],
"platforms": {
"win": {
"quicklaunch": false,
"desktop": false,
"windows_terminal_profile": "Git Bash",
"icon": "C:\\Program Files\\Git\\mingw64\\share\\git\\git-for-windows.ico"
}
}
}
]
}
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Windows Terminal provides the option to application to its profile. This is a handy feature for terminal-based applications.
This PR adds the option to create a Microsoft Terminal profile. It is limited to non-admin installations because, to my knowledge, there is no global
%LOCALAPPDATA%file in which the settings file resides.For now, the terminal profiles are identified by their name, which the terminal uses to create a GUID. It is, in principle, possible to create our own GUIDs using the
uuidmodule from other types of heuristics, but I decided to keep using the name of the menu item to avoid having profiles with duplicate names.Closes #196
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?