Allow arbitrary properties in Info.plist files
#415
Conversation
|
ping |
| raise ValueError( | ||
| f"Duplicate Info.plist property found: {key}. " | ||
| "Remove the property from `info_plist_extra`." | ||
| ) |
There was a problem hiding this comment.
Should we ignore this if they have the same value, and only error if there's a conflict?
There was a problem hiding this comment.
I think raising an exception for any duplication is simpler and keeps the metadata files cleaner.
I'd like to see this taken care of in another PR, where we deprecate the top-level plist keys we don't need in favor of |
I created #419 for this. |
Description
Info.plistfiles contain properties for macOS app bundles.menuinstcurrently supports only a handful of these. Each new properties require a schema update, which does not scale. Moreover, app bundles that contain properties that macOS does not recognize are not invalid and function normally.Instead of continuously adding new properties, add a property that allows shortcut authors to define any
Info.plistproperty. In the future,menuinstshould only explicitly add those that it needs to manipulate and leave other properties to the extra keyword list. Old keywords remain for now to maintain backwards compatibility.This updates the schema version.
Closes #195
Closes #410
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?