Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Test fix for canary builds#495

Merged
lrandersson merged 3 commits into
mainfrom
feature/fix-is-micromamba
Jun 4, 2026
Merged

Test fix for canary builds#495
lrandersson merged 3 commits into
mainfrom
feature/fix-is-micromamba

Conversation

@lrandersson

@lrandersson lrandersson commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

This PR includes a fix for canary builds.
During conda-build CONDA_EXE may point at conda from a separate temporary environment used for building. This PR changes so we use the correct conda during testing.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@lrandersson lrandersson self-assigned this Jun 3, 2026
@lrandersson lrandersson requested a review from a team as a code owner June 3, 2026 14:58
@lrandersson lrandersson changed the title Test fix for canary builds Test fix for canary builds [WIP] Jun 3, 2026
@github-project-automation github-project-automation Bot moved this to πŸ†• New in πŸ”Ž Review Jun 3, 2026
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 3, 2026
Comment thread menuinst/platforms/base.py Outdated
@lrandersson lrandersson marked this pull request as draft June 3, 2026 15:33
Comment thread .github/workflows/tests.yml Outdated
@lrandersson lrandersson changed the title Test fix for canary builds [WIP] Test fix for canary builds Jun 3, 2026
@lrandersson lrandersson force-pushed the feature/fix-is-micromamba branch from 2bbb59d to 03c8e10 Compare June 3, 2026 20:19
Always run canary builds on this branch (REVERT)
Comment thread .github/workflows/tests.yml
@lrandersson lrandersson marked this pull request as ready for review June 3, 2026 21:58

@marcoesters marcoesters left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can you revert the changes to the test workflow? If I approve now and you push changes, you will dismiss my review.

This reverts commit 74dead3.
@lrandersson lrandersson requested a review from marcoesters June 4, 2026 12:52
@github-project-automation github-project-automation Bot moved this from πŸ†• New to βœ… Approved in πŸ”Ž Review Jun 4, 2026
@lrandersson lrandersson merged commit 4719836 into main Jun 4, 2026
17 checks passed
@github-project-automation github-project-automation Bot moved this from βœ… Approved to 🏁 Done in πŸ”Ž Review Jun 4, 2026
@lrandersson lrandersson deleted the feature/fix-is-micromamba branch June 4, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed [bot] added once the contributor has signed the CLA

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

3 participants