Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: improve Android Base64 and Ed25519 key export compatibility - #285

Open
nindanaoto wants to merge 1 commit into
connectbot:mainfrom
nindanaoto:port-fix
Open

nindanaoto wants to merge 1 commit into
connectbot:mainfrom
nindanaoto:port-fix

Conversation

@nindanaoto

Copy link
Copy Markdown

This fixes two compatibility issues found while migrating ConnectBot to cbssh.

  • Fall back to java.util.Base64 only when invoking android.util.Base64 through reflection throws InvocationTargetException. Android Base64 remains the preferred path; this supports JVM/Robolectric environments where its implementation is present but unusable through reflection.
  • Export PKCS#8-encoded Ed25519 private keys without relying on a provider-specific class name. This enables OpenSSH export for Conscrypt keys while invalid or unsupported encodings continue to fail with SshException.

No public API changes.

Validation:

  • ConnectBot OSS and Google debug Kotlin compilation
  • ConnectBot unit-test suite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant