Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Dec 3, 2018

No description provided.

@dqminh
Copy link
Member

dqminh commented Dec 3, 2018

1 commits to fix
The command "DCO_VERBOSITY=-q ../project/script/validate/dco" exited with 1.```

@gliptak can you signoff your commit ?

Signed-off-by: Gábor Lipták <[email protected]>
@codecov-io
Copy link

codecov-io commented Dec 3, 2018

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #70   +/-   ##
======================================
  Coverage    14.3%   14.3%           
======================================
  Files          23      23           
  Lines        4579    4579           
======================================
  Hits          655     655           
  Misses       3803    3803           
  Partials      121     121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc6dde...b49c471. Read the comment docs.

@gliptak
Copy link
Contributor Author

gliptak commented Dec 3, 2018

Thanks @dqminh

@crosbymichael
Copy link
Member

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 10cd53e into containerd:master Dec 7, 2018
@gliptak gliptak deleted the patch-1 branch December 7, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants