cri: add configurable DNS servers for resolving registry hostnames#12951
Open
ChandonPierre wants to merge 2 commits intocontainerd:mainfrom
Open
cri: add configurable DNS servers for resolving registry hostnames#12951ChandonPierre wants to merge 2 commits intocontainerd:mainfrom
ChandonPierre wants to merge 2 commits intocontainerd:mainfrom
Conversation
Signed-off-by: Chandon Pierre <[email protected]>
891ca42 to
b25908a
Compare
Signed-off-by: Chandon Pierre <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are scenarios in which the default system resolver is undesirable for resolving an image host - I.E, a registry that's only resolvable via a private DNS server.
This PR adds a
dns_serversconfig option that allows one to configure DNS servers that get passed into the dial context used for image pulls. If the configured DNS server is unreachable, resolution falls back to the default host resolver as determined bynet.Resolver.Dial.Here, we expose two configuration options:
Global configuration in
config.toml:Per-host via
hosts.toml, overriding the global if set for that host only: