pkg/shim: Fix NewSocket directory permissions#12960
Open
vvoland wants to merge 1 commit intocontainerd:mainfrom
Open
pkg/shim: Fix NewSocket directory permissions#12960vvoland wants to merge 1 commit intocontainerd:mainfrom
vvoland wants to merge 1 commit intocontainerd:mainfrom
Conversation
NewSocket was using the same permission mode (0600) for both the socket file and its parent directory. Directories require the execute bit to be traversable, so creating a directory with 0600 prevents any files from being created inside it. Use 0700 for directory creation while keeping 0600 for socket files. Signed-off-by: Paweł Gronowski <[email protected]>
Member
What files are facing this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewSocket was using the same permission mode (0600) for both the socket file and its parent directory.
Directories require the execute bit to be traversable, so creating a directory with 0600 prevents any files from being created inside it.
Use 0700 for directory creation while keeping 0600 for socket files.